Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump s2n commit in Dockerfile #1563

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Bump s2n commit in Dockerfile #1563

wants to merge 1 commit into from

Conversation

RyanGlScott
Copy link
Contributor

This bumps the s2n commit to GaloisInc/s2n@7f1017e, which points to the llvm_points_to_bitfield changes that were merged into the upstream s2n-tls repo in aws/s2n-tls#3155.

@RyanGlScott
Copy link
Contributor Author

@jldodds, this almost works, save for one hiccup: the bike proof is mysteriously halted by the OOM killer:

[16:00:09.097] Verifying find_err2 ...
[16:00:09.220] Simulating find_err2 ...
[16:00:09.221] Registering overrides for `BIKE1_L1_R1_rotate_right`
[16:00:09.222]   variant `Symbol "BIKE1_L1_R1_rotate_right"`
[16:00:09.222] Registering overrides for `bit_slice_full_subtract`
[16:00:09.223]   variant `Symbol "bit_slice_full_subtract"`
[16:00:09.223] Registering overrides for `bit_sliced_adder`
[16:00:09.223]   variant `Symbol "bit_sliced_adder"`
[16:00:09.227] Matching 1 overrides of  BIKE1_L1_R1_rotate_right ...
[16:00:09.299] Branching on 1 override variants of BIKE1_L1_R1_rotate_right ...
[16:00:09.351] Applied override! BIKE1_L1_R1_rotate_right
[16:00:09.351] Matching 1 overrides of  bit_sliced_adder ...
[16:00:09.467] Branching on 1 override variants of bit_sliced_adder ...
[16:00:09.751] Applied override! bit_sliced_adder
<snip>
[16:03:28.633] Matching 1 overrides of  BIKE1_L1_R1_rotate_right ...
[16:03:28.813] Branching on 1 override variants of BIKE1_L1_R1_rotate_right ...
[16:03:28.917] Applied override! BIKE1_L1_R1_rotate_right
[16:03:28.918] Matching 1 overrides of  bit_sliced_adder ...
[16:03:29.662] Branching on 1 override variants of bit_sliced_adder ...
[16:03:30.134] Applied override! bit_sliced_adder
[16:03:30.135] Matching 1 overrides of  BIKE1_L1_R1_rotate_right ...
[16:03:30.296] Branching on 1 override variants of BIKE1_L1_R1_rotate_right ...
[16:03:30.374] Applied override! BIKE1_L1_R1_rotate_right
[16:03:30.376] Matching 1 overrides of  bit_sliced_adder ...
/bin/bash: line 1: 11393 Killed                  saw bike_r1/verify_bike_r1.saw
     11394 Done                    | tee bike_r1/verify_bike_r1.log
make[1]: *** [bike_r1/verify_bike_r1.log] Error 137
make: *** [bike_r1] Error 2
Makefile:119: recipe for target 'bike_r1/verify_bike_r1.log' failed
make[1]: Leaving directory '/saw-script/s2n/tests/saw'
Makefile:115: recipe for target 'bike_r1' failed
make: Leaving directory '/saw-script/s2n/tests/saw'
2
make: *** [bike] Error 2
Makefile:16: recipe for target 'bike' failed
Error: Process completed with exit code 2.

I'm not quite sure how to explain this one. I suppose it's possible that GitHub Actions' memory is too limited to handle bike, but the fact that this worked on an older commit but not now is concerning.

@RyanGlScott
Bump s2n commit in Dockerfile
ad2b908 
This bumps the `s2n` commit to
GaloisInc/s2n@7f1017e, which points to the
`llvm_points_to_bitfield` changes that were merged into the upstream `s2n-tls`
repo in aws/s2n-tls#3155.
@RyanGlScott
Copy link
Contributor Author

The timeout for each Docker-related test has recently increased from 60 minutes to 120 minutes. Let's see if that makes a difference here.

@RyanGlScott
Copy link
Contributor Author

Hm, I'm afraid not. The bike job is killed well below the 120 minute timeout limit, so this strongly suspects that the amount of memory being used exceeds what the CI runner can support.

@chameco chameco mentioned this pull request Mar 23, 2022
Open
@RyanGlScott RyanGlScott mentioned this pull request Apr 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RyanGlScott